From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [RFC PATCH 1/2] KVM: remove useless check of "ret" variable prior to returning the same value Date: Mon, 30 Mar 2015 16:57:26 +0200 Message-ID: <55196456.9000203@redhat.com> References: <20150328222717.GA6508@gnote> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit To: Eugene Korenevsky , kvm@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:55537 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750938AbbC3O5b (ORCPT ); Mon, 30 Mar 2015 10:57:31 -0400 In-Reply-To: <20150328222717.GA6508@gnote> Sender: kvm-owner@vger.kernel.org List-ID: On 28/03/2015 23:27, Eugene Korenevsky wrote: > A trivial code cleanup. This `if` is redundant. > > Signed-off-by: Eugene Korenevsky > --- > arch/x86/kvm/emulate.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c > index 106c015..3a494f3 100644 > --- a/arch/x86/kvm/emulate.c > +++ b/arch/x86/kvm/emulate.c > @@ -2782,10 +2782,8 @@ static int load_state_from_tss32(struct x86_emulate_ctxt *ctxt, > return ret; > ret = __load_segment_descriptor(ctxt, tss->gs, VCPU_SREG_GS, cpl, > X86_TRANSFER_TASK_SWITCH, NULL); > - if (ret != X86EMUL_CONTINUE) > - return ret; > > - return X86EMUL_CONTINUE; > + return ret; > } > > static int task_switch_32(struct x86_emulate_ctxt *ctxt, > Applied this one for now. Paolo