From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 5/5] KVM: x86: BSP in MSR_IA32_APICBASE is writable Date: Mon, 30 Mar 2015 21:37:13 +0200 Message-ID: <5519A5E9.7090706@redhat.com> References: <1427719163-5429-1-git-send-email-namit@cs.technion.ac.il> <1427719163-5429-6-git-send-email-namit@cs.technion.ac.il> <551959B2.10503@redhat.com> <958ABDE4-051F-45D0-84FA-FF4BC856A7AA@gmail.com> <55196188.3020804@redhat.com> <68F69D11-D45C-497D-B51B-9D85BA2F5891@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Cc: Nadav Amit , mtosatti@redhat.com, kvm@vger.kernel.org To: Nadav Amit Return-path: Received: from mx1.redhat.com ([209.132.183.28]:50355 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753180AbbC3ThY (ORCPT ); Mon, 30 Mar 2015 15:37:24 -0400 In-Reply-To: <68F69D11-D45C-497D-B51B-9D85BA2F5891@gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: On 30/03/2015 21:31, Nadav Amit wrote: > > Because QEMU support for INIT is incomplete, so the tests would fail > > ("Uh, hard reset!"). IIRC sending init to BSP with APIC_DEST_SELF is > > also not supported by actual hardware (or at least not supported > > "officially") so that test would also have to be changed to not use a > > shortcut. > > So, I would revive the init unit-test and disable the failing assertions, > right? Yes, or otherwise mark them as expected failures so that they do not affect the exit code. Paolo > BTW: It appears that there is another bug - DR[0..3] are not reloaded after > reset.