From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH] x86: vdso: fix pvclock races with task migration Date: Tue, 07 Apr 2015 00:04:42 +0200 Message-ID: <552302FA.3090804@redhat.com> References: <1428000263-11892-1-git-send-email-rkrcmar@redhat.com> <5522E789.6070804@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: "linux-kernel@vger.kernel.org" , kvm list , Marcelo Tosatti , stable To: Andy Lutomirski , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= Return-path: Received: from mail-wi0-f169.google.com ([209.85.212.169]:34569 "EHLO mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751563AbbDFWEs (ORCPT ); Mon, 6 Apr 2015 18:04:48 -0400 In-Reply-To: <5522E789.6070804@kernel.org> Sender: kvm-owner@vger.kernel.org List-ID: On 06/04/2015 22:07, Andy Lutomirski wrote: > On 04/02/2015 11:59 AM, Andy Lutomirski wrote: >> On Thu, Apr 2, 2015 at 11:44 AM, Radim Kr=C4=8Dm=C3=A1=C5=99 wrote: >>> If we were migrated right after __getcpu, but before reading the >>> migration_count, we wouldn't notice that we read TSC of a different >>> VCPU, nor that KVM's bug made pvti invalid, as only migration_count >>> on source VCPU is increased. >>> >>> Change vdso instead of updating migration_count on destination. >> >> Looks good to me. >=20 > Just to check: what tree is this intended to go through? I can take = it, > but not until the previous patch makes it into Linus' tree or -tip. = Or > I can take both patches. I'll take it for 4.1. Paolo