From: Jan Kiszka <jan.kiszka@web.de>
To: Valentine Sinitsyn <valentine.sinitsyn@gmail.com>,
kvm <kvm@vger.kernel.org>,
Jailhouse <jailhouse-dev@googlegroups.com>
Subject: Re: SVM: vmload/vmsave-free VM exits?
Date: Tue, 07 Apr 2015 08:35:28 +0200 [thread overview]
Message-ID: <55237AB0.7080904@web.de> (raw)
In-Reply-To: <55237957.7010408@gmail.com>
On 2015-04-07 08:29, Valentine Sinitsyn wrote:
> On 07.04.2015 11:23, Jan Kiszka wrote:
>> On 2015-04-07 08:19, Valentine Sinitsyn wrote:
>>> On 07.04.2015 11:13, Jan Kiszka wrote:
>>>>>> It is, at least 160 cycles with hot caches on an AMD A6-5200 APU,
>>>>>> more
>>>>>> towards 600 if they are colder (added some usleep to each loop in the
>>>>>> test).
>>>>> Great, thanks. Could you post absolute numbers, i.e how long do A
>>>>> and B
>>>>> take on your CPU?
>>>>
>>>> A is around 1910 cycles, B about 1750.
>>> It's with hot caches I guess? Not bad anyways, it's a pity I didn't
>>> observe this and didn't include this optimization from the day one.
>>
>> Yes, that is with the unmodified benchmark I sent. When I add, say
>> usleep(1000) to that loop body, the cycles jumped to 4k (IIRC).
>>
>> BTW, this is the Jailhouse patch:
>> https://github.com/siemens/jailhouse/commit/dbf2fe479ac07a677462dfa87e008e37a4e72858
>>
> I guess, it's getting off-topic here, but wouldn't it be cleaner to
> simply use wrmsr and rdmsr instead of vmload and vmsave in svm-vmexit.S?
> This would require less changes and will keep all entry/exit setup code
> in one place.
It's a tradeoff between assembly lines and C statements. My feeling is
that it's easier done in C, but you can prove me wrong.
Jan
--
You received this message because you are subscribed to the Google Groups "Jailhouse" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jailhouse-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2015-04-07 6:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-05 8:31 SVM: vmload/vmsave-free VM exits? Jan Kiszka
2015-04-05 17:12 ` Valentine Sinitsyn
2015-04-07 5:43 ` Jan Kiszka
2015-04-07 6:10 ` Valentine Sinitsyn
2015-04-07 6:13 ` Jan Kiszka
2015-04-07 6:19 ` Valentine Sinitsyn
2015-04-07 6:23 ` Jan Kiszka
2015-04-07 6:29 ` Valentine Sinitsyn
2015-04-07 6:35 ` Jan Kiszka [this message]
2015-04-13 7:01 ` Jan Kiszka
2015-04-13 17:29 ` Avi Kivity
2015-04-13 17:35 ` Jan Kiszka
2015-04-13 17:41 ` Avi Kivity
2015-04-13 17:48 ` Avi Kivity
2015-04-13 17:57 ` Jan Kiszka
2015-04-13 18:07 ` Avi Kivity
2015-04-13 18:14 ` Jan Kiszka
2015-04-14 6:39 ` Valentine Sinitsyn
2015-04-14 7:02 ` Jan Kiszka
2015-04-14 7:11 ` Valentine Sinitsyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55237AB0.7080904@web.de \
--to=jan.kiszka@web.de \
--cc=jailhouse-dev@googlegroups.com \
--cc=kvm@vger.kernel.org \
--cc=valentine.sinitsyn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox