From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v2 4/4] KVM: x86: simplify kvm_apic_map
Date: Tue, 07 Apr 2015 14:38:08 +0200
Message-ID: <5523CFB0.7040409@redhat.com>
References: <1423766494-26150-1-git-send-email-rkrcmar@redhat.com> <1423766494-26150-5-git-send-email-rkrcmar@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: kvm@vger.kernel.org, Nadav Amit <namit@cs.technion.ac.il>,
	Gleb Natapov <gleb@kernel.org>
To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
	linux-kernel@vger.kernel.org
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <1423766494-26150-5-git-send-email-rkrcmar@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org



On 12/02/2015 19:41, Radim Kr=C4=8Dm=C3=A1=C5=99 wrote:
> +static inline void
> +apic_logical_id(struct kvm_apic_map *map, u32 dest_id, u16 *cid, u16=
 *lid)
> +{
> +	BUILD_BUG_ON(KVM_APIC_MODE_XAPIC_CLUSTER !=3D  4);
> +	BUILD_BUG_ON(KVM_APIC_MODE_XAPIC_FLAT    !=3D  8);
> +	BUILD_BUG_ON(KVM_APIC_MODE_X2APIC        !=3D 16);
> +

I added

	unsigned lid_bits =3D map->mode;

here (used in the rest of apic_logical_id) and applied the series.

Thanks,

Paolo

> +	*cid =3D dest_id >> map->mode;
> +	*lid =3D dest_id & ((1 << map->mode) - 1);
> +}