From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Huang Subject: Re: [PATCH V2 0/5] KVM vPMU support for AMD Date: Wed, 08 Apr 2015 11:22:46 -0500 Message-ID: <552555D6.5050309@redhat.com> References: <1428509905-32352-1-git-send-email-wei@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: pbonzini@redhat.com, rkrcmar@redhat.com, gleb@kernel.org To: kvm@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:36715 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753641AbbDHQWy (ORCPT ); Wed, 8 Apr 2015 12:22:54 -0400 In-Reply-To: <1428509905-32352-1-git-send-email-wei@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Hi Radim: This version should address most of your comments to V1. Please help to review it. Hi Paolo: This version has been polished since V1. Could you please review it? Thanks, -Wei On 04/08/2015 11:18 AM, Wei Huang wrote: > Currently KVM only supports vPMU for Intel platforms. This patch set > enable vPMU support for AMD platform by creating a common PMU > interface for x86. The PMU calls from guest VMs are dispatched > to corresponding functions defined in arch specific files. > > V2: > * Create a generic pmu.c file which is shared by Intel and AMD CPUs; > * pmu.c code becomes part of kvm.ko module. Similarly pmu_intel.c and > pmu_amd.c are linked to kvm-intel.ko and kvm-amd.ko respectively; > * Re-define kvm_pmu_ops function pointers. Per Radim Krcmar's comments, > a large portion of Intel vPMU code are now consolidated and moved to > pmu.c; > * Polish pmu_amd.c code to comply with new definition of kvm_pmu_ops; > > V1: > * Adopt the file layout suggested by Radim Krcmar > * Link arch module with its specific PMU file > > RFC: > * Initial version for RFC > > Wei Huang (5): > KVM: x86/vPMU: Define kvm_pmu_ops to support vPMU function dispatch > KVM: x86/vPMU: Rename pmu.c file to pmu_intel.c > KVM: x86/vPMU: Create vPMU interface for VMX and SVM > KVM: x86/vPMU: Implement vPMU code AMD CPUs > KVM: x86/vPMU: Enable PMU handling for AMD PERFCTRn and EVNTSELn MSRs > > arch/x86/include/asm/kvm_host.h | 38 ++- > arch/x86/kvm/Makefile | 4 +- > arch/x86/kvm/cpuid.c | 3 +- > arch/x86/kvm/pmu.c | 563 +++++++++++----------------------------- > arch/x86/kvm/pmu.h | 98 +++++++ > arch/x86/kvm/pmu_amd.c | 198 ++++++++++++++ > arch/x86/kvm/pmu_intel.c | 360 +++++++++++++++++++++++++ > arch/x86/kvm/svm.c | 8 + > arch/x86/kvm/vmx.c | 8 + > arch/x86/kvm/x86.c | 57 ++-- > 10 files changed, 896 insertions(+), 441 deletions(-) > create mode 100644 arch/x86/kvm/pmu.h > create mode 100644 arch/x86/kvm/pmu_amd.c > create mode 100644 arch/x86/kvm/pmu_intel.c >