From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH] x86-run: Print a meaningful message if the qemu binary isn't found Date: Thu, 09 Apr 2015 19:17:19 +0200 Message-ID: <5526B41F.8020205@redhat.com> References: <551D3A47.1030404@redhat.com> <5526AC5E.7050803@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Marcelo Tosatti To: Bandan Das Return-path: Received: from mx1.redhat.com ([209.132.183.28]:42260 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753904AbbDIRb6 (ORCPT ); Thu, 9 Apr 2015 13:31:58 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 3D1E78E680 for ; Thu, 9 Apr 2015 17:31:58 +0000 (UTC) In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 09/04/2015 19:14, Bandan Das wrote: > Paolo Bonzini writes: > ... >> This breaks "QEMU=... ./x86-run ./x86/msr.flat" >> >> Fixed as follows: >> >> diff --git a/x86/run b/x86/run >> index d5adf8d..219a93b 100755 >> --- a/x86/run >> +++ b/x86/run >> @@ -20,16 +20,15 @@ else >> break >> fi >> done >> -fi >> - >> -if [ -z "${QEMUFOUND}" ] >> -then >> - echo "A QEMU binary was not found, You can set a custom location by using the QEMU= environment variable " >> - exit ${NOTFOUND} >> -elif [ -z "${qemu}" ] >> -then >> - echo "No Qemu test device support found" >> - exit ${TESTDEVNOTSUPP} >> + if [ -z "${QEMUFOUND}" ] >> + then >> + echo "A QEMU binary was not found, You can set a custom location by using the QEMU= environment variable " >> + exit ${NOTFOUND} >> + elif [ -z "${qemu}" ] >> + then >> + echo "No Qemu test device support found" > > I think we still want to print this if the user supplied qemu has no test > device support. Yes, but we do not go through the "for" in that case... Can you make a patch on top of master? Paolo