From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH] KVM: reuse memslot in kvm_write_guest_page Date: Sat, 11 Apr 2015 15:09:59 +0200 Message-ID: <55291D27.8070008@redhat.com> References: <1428695247-27603-1-git-send-email-rkrcmar@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , KVM list Return-path: Received: from mail-wi0-f179.google.com ([209.85.212.179]:37941 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752852AbbDKNKE (ORCPT ); Sat, 11 Apr 2015 09:10:04 -0400 Received: by wiun10 with SMTP id n10so23956295wiu.1 for ; Sat, 11 Apr 2015 06:10:03 -0700 (PDT) In-Reply-To: <1428695247-27603-1-git-send-email-rkrcmar@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 10/04/2015 21:47, Radim Kr=C4=8Dm=C3=A1=C5=99 wrote: > Saves one O(log N) search. >=20 > Signed-off-by: Radim Kr=C4=8Dm=C3=A1=C5=99 > --- > I'm still not sure how to bridge the gap between the code we have an= d > the code I want, but all routes so far contained this change. Notic= e > that we use '_memslot' and '_in_slot' suffix for the same meaning ..= =2E > (And the completely useless 'kvm' parameter for page dirtying.) I have the same patch (plus exporting mark_dirty_page_in_slot and removing the extra 'kvm' parameter :)) in my SMM queue. I'll replace i= t with yours. Paolo