From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH] KVM: x86: Fix MSR_IA32_BNDCFGS in msrs_to_save Date: Mon, 13 Apr 2015 12:08:22 +0200 Message-ID: <552B9596.10608@redhat.com> References: <1428864435-4732-1-git-send-email-namit@cs.technion.ac.il> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Nadav Amit Return-path: Received: from mx1.redhat.com ([209.132.183.28]:46208 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753803AbbDMKId (ORCPT ); Mon, 13 Apr 2015 06:08:33 -0400 In-Reply-To: <1428864435-4732-1-git-send-email-namit@cs.technion.ac.il> Sender: kvm-owner@vger.kernel.org List-ID: On 12/04/2015 20:47, Nadav Amit wrote: > kvm_init_msr_list is currently called before hardware_setup. As a result, > vmx_mpx_supported always returns false when kvm_init_msr_list checks whether to > save MSR_IA32_BNDCFGS. > > Move kvm_init_msr_list after vmx_hardware_setup is called to fix this issue. > > Signed-off-by: Nadav Amit > > --- > > Note that this patch was not tested on a system that supports MPX. > --- > arch/x86/kvm/x86.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index b8cb1d0..b7e3b05 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -5800,7 +5800,6 @@ int kvm_arch_init(void *opaque) > kvm_set_mmio_spte_mask(); > > kvm_x86_ops = ops; > - kvm_init_msr_list(); > > kvm_mmu_set_mask_ptes(PT_USER_MASK, PT_ACCESSED_MASK, > PT_DIRTY_MASK, PT64_NX_MASK, 0); > @@ -7254,7 +7253,14 @@ void kvm_arch_hardware_disable(void) > > int kvm_arch_hardware_setup(void) > { > - return kvm_x86_ops->hardware_setup(); > + int r; > + > + r = kvm_x86_ops->hardware_setup(); > + if (r != 0) > + return r; > + > + kvm_init_msr_list(); > + return 0; > } > > void kvm_arch_hardware_unsetup(void) > Applied (locally) for 4.1 with Cc stable. Paolo