From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [Qemu-devel][PATCH 2/2] target-i386: kvm: Disable KVM quirks Date: Mon, 13 Apr 2015 16:13:25 +0200 Message-ID: <552BCF05.8020504@redhat.com> References: <1428881529-29459-1-git-send-email-namit@cs.technion.ac.il> <1428881529-29459-3-git-send-email-namit@cs.technion.ac.il> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org, jan.kiszka@siemens.com, bsd@redhat.com, avi.kivity@gmail.com To: Nadav Amit Return-path: Received: from mx1.redhat.com ([209.132.183.28]:51195 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752946AbbDMONk (ORCPT ); Mon, 13 Apr 2015 10:13:40 -0400 In-Reply-To: <1428881529-29459-3-git-send-email-namit@cs.technion.ac.il> Sender: kvm-owner@vger.kernel.org List-ID: On 13/04/2015 01:32, Nadav Amit wrote: > + if (kvm_check_extension(s, KVM_CAP_ENABLE_CAP_VM)) { The right capability to check here is KVM_CAP_DISABLE_QUIRKS, not KVM_CAP_ENABLE_CAP_VM. Paolo > + ret = kvm_vm_enable_cap(s, KVM_CAP_DISABLE_QUIRKS, 0, > + KVM_QUIRK_LINT0_DISABLED | > + KVM_QUIRK_CD_NW_CLEARED); > + if (ret < 0) { > + return ret; > + } > + }