From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] target-i386: kvm: Disable KVM quirks
Date: Mon, 13 Apr 2015 16:24:55 +0200
Message-ID: <552BD1B7.4080103@redhat.com>
References: <1428881529-29459-1-git-send-email-namit@cs.technion.ac.il> <1428881529-29459-3-git-send-email-namit@cs.technion.ac.il> <552BCF05.8020504@redhat.com> <D4B2EE7B-9F20-41CC-B320-FAAF0BD5E06C@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: Nadav Amit <namit@cs.technion.ac.il>,
	Jan Kiszka <jan.kiszka@siemens.com>,
	Bandan Das <bsd@redhat.com>, qemu-devel@nongnu.org,
	kvm list <kvm@vger.kernel.org>, avi.kivity@gmail.com
To: Nadav Amit <nadav.amit@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:55051 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754078AbbDMOZL (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 13 Apr 2015 10:25:11 -0400
In-Reply-To: <D4B2EE7B-9F20-41CC-B320-FAAF0BD5E06C@gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>



On 13/04/2015 16:17, Nadav Amit wrote:
> Paolo Bonzini <pbonzini@redhat.com> wrote:
>=20
>>
>>
>> On 13/04/2015 01:32, Nadav Amit wrote:
>>> +    if (kvm_check_extension(s, KVM_CAP_ENABLE_CAP_VM)) {
>>
>> The right capability to check here is KVM_CAP_DISABLE_QUIRKS, not
>> KVM_CAP_ENABLE_CAP_VM.
>>
>> Paolo
>>
>>> +        ret =3D kvm_vm_enable_cap(s, KVM_CAP_DISABLE_QUIRKS, 0,
>>> +                                KVM_QUIRK_LINT0_DISABLED |
>>> +                                KVM_QUIRK_CD_NW_CLEARED);
>>> +        if (ret < 0) {
>>> +            return ret;
>>> +        }
>>> +    }
>=20
> Of course=85
> Do you want a v2 now, later (after 4.2), or would you change it yours=
elf?

Later, close to 4.2 but not necessarily after it.

Paolo