From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH] KVM: x86: tweak types of fields in kvm_lapic_irq Date: Wed, 22 Apr 2015 12:27:55 +0200 Message-ID: <553777AB.7080909@redhat.com> References: <1429635686-82328-1-git-send-email-pbonzini@redhat.com> <20150422093542.GA30285@potion.brq.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= Return-path: In-Reply-To: <20150422093542.GA30285@potion.brq.redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 22/04/2015 11:35, Radim Kr=C4=8Dm=C3=A1=C5=99 wrote: > > Change the level field to bool, since we assign 1 sometimes, but > > just mask icr_low with APIC_INT_ASSERT in apic_send_-ipi. >=20 > Would be more consistent to change that assignment instead ... > If we dropped the idea that struct kvm_lapic_irq fields can be bitORe= d > to get the ICR, we could also easily change trig_mode/dest_mode to bo= ol > level_trig/logical_dest. (I can do a followup patch.) Right, I thought of both. However, level is something that has an obviously understandable meaning as a bool, while trig_mode/dest_mode a= s you said have to be renamed as well. You're right on the u8 type for vector, too. But I probably will end u= p not committing this patch at all... Paolo