From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Subject: Re: [PATCH] KVM: x86: drop unneeded null test Date: Tue, 28 Apr 2015 19:21:39 +0200 Message-ID: <553FC1A3.70206@users.sourceforge.net> References: <1430166934-30834-1-git-send-email-Julia.Lawall@lip6.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Cc: Gleb Natapov , "Michael S . Tsirkin" , zhanghy@sangfor.com, jasowang@redhat.com, kernel-janitors@vger.kernel.org, Paolo Bonzini , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org To: Julia Lawall Return-path: In-Reply-To: <1430166934-30834-1-git-send-email-Julia.Lawall@lip6.fr> Sender: kernel-janitors-owner@vger.kernel.org List-Id: kvm.vger.kernel.org > If the null test is needed, the call to cancel_delayed_work_sync would have > already crashed. Normally, the destroy function should only be called > if the init functoin has succeeded, in which case ioapic is not null. Does your commit message need a small fix? Regards, Markus