From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH] KVM: nVMX: Don't return error on nested bitmap memory allocation failure Date: Wed, 29 Apr 2015 10:17:35 +0200 Message-ID: <5540939F.70506@redhat.com> References: <9C58F44B-0406-4273-BB36-50D39B7C33F9@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: kvm list , Jan Kiszka , Wincy Van , linux-kernel@vger.kernel.org To: Nadav Amit , Bandan Das Return-path: In-Reply-To: <9C58F44B-0406-4273-BB36-50D39B7C33F9@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 29/04/2015 09:27, Nadav Amit wrote: > free_page appears to check whether the address is zero before it actually > frees the page. Perhaps it is better to leverage this behaviour to remove > all the outX and simplify the code. Agreed. Regarding this patch, I agree with Jan. Paolo