* [PATCH kvm-unit-tests] x86: vmx: Remove bogus GUEST_RIP update from interrupt test
@ 2015-05-04 8:12 Jan Kiszka
0 siblings, 0 replies; only message in thread
From: Jan Kiszka @ 2015-05-04 8:12 UTC (permalink / raw)
To: Paolo Bonzini, kvm
When we get an EXTINT exit, the guest RIP already points to the
instruction after the one that sent it into HLT state. Moving
the RIP based on stale insn_len caused spurious L2 crashes.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
x86/vmx_tests.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/x86/vmx_tests.c b/x86/vmx_tests.c
index 4f8ace1..79552fd 100644
--- a/x86/vmx_tests.c
+++ b/x86/vmx_tests.c
@@ -1297,10 +1297,8 @@ static int interrupt_exit_handler(void)
asm volatile ("nop");
irq_disable();
}
- if (vmx_get_test_stage() >= 2) {
+ if (vmx_get_test_stage() >= 2)
vmcs_write(GUEST_ACTV_STATE, ACTV_ACTIVE);
- vmcs_write(GUEST_RIP, guest_rip + insn_len);
- }
return VMX_TEST_RESUME;
default:
printf("Unknown exit reason, %d\n", reason);
--
2.1.4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2015-05-04 8:12 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-04 8:12 [PATCH kvm-unit-tests] x86: vmx: Remove bogus GUEST_RIP update from interrupt test Jan Kiszka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).