From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [PATCH v2 3/9] KVM: MMU: introduce for_each_slot_rmap_range Date: Tue, 12 May 2015 17:38:41 +0800 Message-ID: <5551CA21.7030001@linux.intel.com> References: <1431397953-16642-1-git-send-email-guangrong.xiao@linux.intel.com> <1431397953-16642-4-git-send-email-guangrong.xiao@linux.intel.com> <5551B848.4090606@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: gleb@kernel.org, mtosatti@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org To: Paolo Bonzini Return-path: In-Reply-To: <5551B848.4090606@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 05/12/2015 04:22 PM, Paolo Bonzini wrote: > > > On 12/05/2015 04:32, Xiao Guangrong wrote: >> +#define for_each_slot_rmap_range(_slot_, _start_level_, _end_level_, \ >> + _start_gfn, _end_gfn, _iter_) \ >> + for (slot_rmap_walk_init(_iter_, _slot_, _start_level_, \ >> + _end_level_, _start_gfn, _end_gfn); \ >> + slot_rmap_walk_okay(_iter_); \ >> + slot_rmap_walk_next(_iter_)) >> + > > >> + for_each_slot_rmap_range(memslot, PT_PAGE_TABLE_LEVEL, >> + PT_PAGE_TABLE_LEVEL + KVM_NR_PAGE_SIZES - 1, > > > What about adding a > > #define for PT_MAX_HUGEPAGE_LEVEL (PT_PAGE_TABLE_LEVEL + KVM_NR_PAGE_SIZES - 1) Good to me. > > ? > >> + gfn_start, gfn_end - 1, &iterator) >> + ret |= handler(kvm, iterator.rmap, memslot, >> + iterator.gfn, iterator.level, data); > > I prefer to indent by two tabs: > > for_each_slot_rmap_range(memslot, > PT_PAGE_TABLE_LEVEL, PT_MAX_HUGEPAGE_LEVEL, > gfn_start, gfn_end - 1, &iterator) > ret |= handler(kvm, iterator.rmap, memslot, > iterator.gfn, iterator.level, data); > > > Same in the next patch: > > for_each_slot_rmap_range(memslot, > start_level, end_level, > start_gfn, end_gfn, &iterator) { > if (iterator.rmap) > flush |= fn(kvm, iterator.rmap); > ... > } looks nice, will follow your style. :)