From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH v3 09/10] KVM: MMU: fix MTRR update Date: Wed, 13 May 2015 16:10:08 +0200 Message-ID: <55535B40.2060504@redhat.com> References: <1431499348-25188-1-git-send-email-guangrong.xiao@linux.intel.com> <1431499348-25188-10-git-send-email-guangrong.xiao@linux.intel.com> <20150513084341.GA4910@kernel> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: gleb@kernel.org, mtosatti@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org To: Wanpeng Li , Xiao Guangrong Return-path: Received: from mx1.redhat.com ([209.132.183.28]:38197 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933065AbbEMOKU (ORCPT ); Wed, 13 May 2015 10:10:20 -0400 In-Reply-To: <20150513084341.GA4910@kernel> Sender: kvm-owner@vger.kernel.org List-ID: On 13/05/2015 10:43, Wanpeng Li wrote: > kvm_mmu_reset_context > kvm_mmu_unload > mmu_free_roots > > The original root shadow page will be freed in mmu_free_roots, where I > miss? > > Another question maybe not related to this patch: > > If kvm_mmu_reset_context is just called to destroy the original root > shadow page and all the sptes will remain valid? SPTEs are kept around and cached. The "role" field is used as the hash key; if the role doesn't change, SPTEs are reused, so you have to zap the SPTEs explicitly. Paolo