From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 06/12] KVM: x86: API changes for SMM support Date: Thu, 21 May 2015 16:59:50 +0200 Message-ID: <555DF2E6.1020003@redhat.com> References: <1431084034-8425-1-git-send-email-pbonzini@redhat.com> <1431084034-8425-7-git-send-email-pbonzini@redhat.com> <20150521144954.GA10453@potion.brq.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, bsd@redhat.com To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= Return-path: In-Reply-To: <20150521144954.GA10453@potion.brq.redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 21/05/2015 16:49, Radim Kr=C4=8Dm=C3=A1=C5=99 wrote: > 2015-05-08 13:20+0200, Paolo Bonzini: >> diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h >> @@ -202,7 +202,7 @@ struct kvm_run { >> __u32 exit_reason; >> __u8 ready_for_interrupt_injection; >> __u8 if_flag; >> - __u8 padding2[2]; >> + __u16 flags; >=20 > (It got lost last review and I'd really like to know ... > what is the advantage of giving both bytes to flags?) No advantage. You just should leave padding2[1] in the middle so that the offset of &run->padding2[0] doesn't change. Since it's not obvious I gave two bytes to flags, but I can do it either way. Paolo