From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v2] i386: Introduce ARAT CPU feature
Date: Mon, 25 May 2015 16:16:14 +0200
Message-ID: <55632EAE.9030508@redhat.com>
References: <5561EB59.5000407@web.de> <5563225B.60200@redhat.com> <55632C7A.8010107@web.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: 7bit
Cc: qemu-devel <qemu-devel@nongnu.org>, kvm <kvm@vger.kernel.org>
To: Jan Kiszka <jan.kiszka@web.de>,
	Eduardo Habkost <ehabkost@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:52825 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751382AbbEYOQT (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 25 May 2015 10:16:19 -0400
In-Reply-To: <55632C7A.8010107@web.de>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>



On 25/05/2015 16:06, Jan Kiszka wrote:
>  static void pc_compat_2_3(MachineState *machine)
>  {
> +    x86_cpu_compat_set_features("Westmere", FEAT_6_EAX, 0, CPUID_6_EAX_ARAT);
> +    x86_cpu_compat_set_features("SandyBridge", FEAT_6_EAX, 0,
> +                                CPUID_6_EAX_ARAT);
> +    x86_cpu_compat_set_features("IvyBridge", FEAT_6_EAX, 0, CPUID_6_EAX_ARAT);
> +    x86_cpu_compat_set_features("Haswell-noTSX", FEAT_6_EAX, 0,
> +                                CPUID_6_EAX_ARAT);
> +    x86_cpu_compat_set_features("Haswell", FEAT_6_EAX, 0, CPUID_6_EAX_ARAT);
> +    x86_cpu_compat_set_features("Broadwell-noTSC", FEAT_6_EAX, 0,
> +                                CPUID_6_EAX_ARAT);

noTSX.

Also, I think this doesn't cover Q35.  Eduardo has patches to clean that
up so that (I think) less duplication is required.

Paolo

> +    x86_cpu_compat_set_features("Broadwell", FEAT_6_EAX, 0, CPUID_6_EAX_ARAT);
>  }
>