From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 1/2] KVM: MMU: fix SMAP virtualization Date: Tue, 26 May 2015 16:48:06 +0200 Message-ID: <556487A6.2020804@redhat.com> References: <556486F3.5020007@solarflare.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Xiao Guangrong , gleb@kernel.org, mtosatti@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org To: Edward Cree , Bandan Das Return-path: In-Reply-To: <556486F3.5020007@solarflare.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 26/05/2015 16:45, Edward Cree wrote: >>> This breaks older compilers that can't initialize anon structures. >> > >> > How old ? Even gcc 3.1 says you can use unnamed struct/union fields and >> > 3.2 is the minimum version required to compile the kernel as mentioned >> > in the README. >> > >> > We could simply just name the structure, but I doubt this is the >> > only place in the kernel code where it's being used this way :) > This appears to be GCC bug #10676, see > Says it was fixed in 4.6, but I believe the kernel supports GCCs much older > than that (back to 3.2). I personally hit it on 4.4.7, the version shipped > with RHEL6.6. Yes, it will be fixed soon(ish). Probably before you can get rid of the obnoxious disclaimer... :) Paolo > The information contained in this message is confidential and is > intended for the addressee(s) only. If you have received this message > in error, please notify the sender immediately and delete the > message. Unless you are an addressee (or authorized to receive for an > addressee), you may not use, copy or disclose to anyone this message > or any information contained in this message. The unauthorized use, > disclosure, copying or alteration of this message is strictly > prohibited.