From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH v2 00/13] SMM implementation for KVM Date: Thu, 04 Jun 2015 15:49:48 +0200 Message-ID: <5570577C.20609@redhat.com> References: <1432746314-50196-1-git-send-email-pbonzini@redhat.com> <20150604122655.GB13488@potion.brq.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, guangrong.xiao@linux.intel.com, bdas@redhat.com To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= Return-path: Received: from mx1.redhat.com ([209.132.183.28]:54888 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932173AbbFDNtx (ORCPT ); Thu, 4 Jun 2015 09:49:53 -0400 In-Reply-To: <20150604122655.GB13488@potion.brq.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 04/06/2015 14:26, Radim Kr=C4=8Dm=C3=A1=C5=99 wrote: > A list of minor stuff I noticed (you'll probably agree with [12/13]): Good eyes. :) I'll fix at least these: > [06/13] get_smstate can't be a valid C function, CAPS would be cleare= r > [06/13] mangled whitespace in trace_kvm_enter_smm > [08/13] '(u16)' or '0xffff &' seem better than '65535 &' > [12/13] add role.smm to Documentation/virtual/kvm/mmu.txt Paolo