From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH v2 06/13] KVM: x86: save/load state on SMM switch Date: Thu, 04 Jun 2015 15:59:32 +0200 Message-ID: <557059C4.1060601@redhat.com> References: <1432746314-50196-1-git-send-email-pbonzini@redhat.com> <1432746314-50196-7-git-send-email-pbonzini@redhat.com> <20150603190253.GA13488@potion.brq.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, guangrong.xiao@linux.intel.com, bdas@redhat.com To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= Return-path: In-Reply-To: <20150603190253.GA13488@potion.brq.redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 03/06/2015 21:02, Radim Kr=C4=8Dm=C3=A1=C5=99 wrote: > > + if (r < 0) > > + return; >=20 > And if we fail to write it, is there other option than throwing an er= ror > to userspace? (Unset HF_SMM_MASK and pretend that nothing happened > doesn't find much support in docs.) Just do nothing, I guess. If this is ROM, things will work (for some definition of work) the same as in real hardware. If it's MMIO, they will break as soon as the next instruction is executed. Paolo