From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH v2 07/13] KVM: add vcpu-specific functions to read/write/translate GFNs Date: Fri, 05 Jun 2015 14:43:39 +0200 Message-ID: <5571997B.9090705@redhat.com> References: <1432746314-50196-1-git-send-email-pbonzini@redhat.com> <1432746314-50196-8-git-send-email-pbonzini@redhat.com> <20150529192346.GA11651@potion.brq.redhat.com> <5571795B.6080204@redhat.com> <20150605121051.GD11957@potion.brq.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, guangrong.xiao@linux.intel.com, bdas@redhat.com To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= Return-path: Received: from mx1.redhat.com ([209.132.183.28]:53507 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751210AbbFEMnn (ORCPT ); Fri, 5 Jun 2015 08:43:43 -0400 In-Reply-To: <20150605121051.GD11957@potion.brq.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 05/06/2015 14:10, Radim Kr=C4=8Dm=C3=A1=C5=99 wrote: > 2015-06-05 12:26+0200, Paolo Bonzini: >> On 29/05/2015 21:23, Radim Kr=C4=8Dm=C3=A1=C5=99 wrote: >>>>> +int kvm_vcpu_write_guest(struct kvm_vcpu *vcpu, gpa_t gpa, const= void *data, >>>>> + unsigned long len) >>>>> +{ > | [...] >>>>> +} >>> (There is no need to pass vcpu, and kvm, in this API. >> >> How so? A single kvm_vcpu_write_guest can cross multiple slots. >=20 > I meant passing 'struct kvm_memslots *' instead and as soon as possib= le, > which would still allow more slots. Oh, indeed that works fine! Paolo