From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
To: David Matlack <dmatlack@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Gleb Natapov <gleb@kernel.org>,
Marcelo Tosatti <mtosatti@redhat.com>,
kvm list <kvm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 09/15] KVM: MTRR: introduce var_mtrr_range
Date: Tue, 09 Jun 2015 10:38:55 +0800 [thread overview]
Message-ID: <557651BF.5060900@linux.intel.com> (raw)
In-Reply-To: <CALzav=fSxAb8cK8icBkcyVovuEsiz3muhL6HPJEUS+MLmw4dqQ@mail.gmail.com>
Thanks for your review, David!
On 06/09/2015 08:36 AM, David Matlack wrote:
>> static void update_mtrr(struct kvm_vcpu *vcpu, u32 msr)
>> {
>> struct kvm_mtrr *mtrr_state = &vcpu->arch.mtrr_state;
>> - gfn_t start, end, mask;
>> + gfn_t start, end;
>> int index;
>>
>> if (msr == MSR_IA32_CR_PAT || !tdp_enabled ||
>> @@ -244,11 +255,7 @@ static void update_mtrr(struct kvm_vcpu *vcpu, u32 msr)
>> default:
>> /* variable range MTRRs. */
>> index = (msr - 0x200) / 2;
>> - start = mtrr_state->var_ranges[index].base & PAGE_MASK;
>> - mask = mtrr_state->var_ranges[index].mask & PAGE_MASK;
>> - mask |= ~0ULL << cpuid_maxphyaddr(vcpu);
>
> Why did you drop this in favor of boot_cpu_data.x86_phys_bits?
>
It can make the code more generic, @vcpu is not needed anymore.
next prev parent reply other threads:[~2015-06-09 2:38 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-30 10:59 [PATCH 00/15] KVM: x86: fully implement vMTRR Xiao Guangrong
2015-05-30 10:58 ` Xiao Guangrong
2015-05-30 10:59 ` [PATCH 01/15] KVM: x86: move MTRR related code to a separate file Xiao Guangrong
2015-05-30 10:59 ` [PATCH 02/15] KVM: MTRR: handle MSR_MTRRcap in kvm_mtrr_get_msr Xiao Guangrong
2015-05-30 10:59 ` [PATCH 03/15] KVM: MTRR: remove mtrr_state.have_fixed Xiao Guangrong
2015-05-30 10:59 ` [PATCH 04/15] KVM: MTRR: exactly define the size of variable MTRRs Xiao Guangrong
2015-05-30 10:59 ` [PATCH 05/15] KVM: MTRR: clean up mtrr default type Xiao Guangrong
2015-06-01 9:11 ` Paolo Bonzini
2015-06-03 1:55 ` Xiao Guangrong
2015-06-09 0:35 ` David Matlack
2015-05-30 10:59 ` [PATCH 06/15] KVM: MTRR: do not split 64 bits MSR content Xiao Guangrong
2015-05-30 10:59 ` [PATCH 07/15] KVM: MTRR: improve kvm_mtrr_get_guest_memory_type Xiao Guangrong
2015-06-01 9:16 ` Paolo Bonzini
2015-06-03 2:12 ` Xiao Guangrong
2015-06-03 7:57 ` Paolo Bonzini
2015-05-30 10:59 ` [PATCH 08/15] KVM: MTRR: introduce fixed_mtrr_segment table Xiao Guangrong
2015-06-01 9:25 ` Paolo Bonzini
2015-06-03 2:29 ` Xiao Guangrong
2015-05-30 10:59 ` [PATCH 09/15] KVM: MTRR: introduce var_mtrr_range Xiao Guangrong
2015-06-09 0:36 ` David Matlack
2015-06-09 2:38 ` Xiao Guangrong [this message]
2015-05-30 10:59 ` [PATCH 10/15] KVM: MTRR: sort variable MTRRs Xiao Guangrong
2015-06-01 9:27 ` Paolo Bonzini
2015-06-03 2:31 ` Xiao Guangrong
2015-05-30 10:59 ` [PATCH 11/15] KVM: MTRR: introduce fixed_mtrr_addr_* functions Xiao Guangrong
2015-05-30 10:59 ` [PATCH 12/15] KVM: MTRR: introduce mtrr_for_each_mem_type Xiao Guangrong
2015-06-01 9:33 ` Paolo Bonzini
2015-06-01 14:26 ` Paolo Bonzini
2015-06-03 2:57 ` Xiao Guangrong
2015-06-03 2:40 ` Xiao Guangrong
2015-06-09 0:36 ` David Matlack
2015-06-09 2:45 ` Xiao Guangrong
2015-05-30 10:59 ` [PATCH 13/15] KVM: MTRR: simplify kvm_mtrr_get_guest_memory_type Xiao Guangrong
2015-05-30 10:59 ` [PATCH 14/15] KVM: MTRR: do not map huage page for non-consistent range Xiao Guangrong
2015-06-01 9:36 ` Paolo Bonzini
2015-06-01 9:38 ` Paolo Bonzini
2015-06-03 2:56 ` Xiao Guangrong
2015-06-03 7:55 ` Paolo Bonzini
2015-06-04 8:23 ` Xiao Guangrong
2015-06-04 8:26 ` Xiao Guangrong
2015-06-04 8:34 ` Paolo Bonzini
2015-06-04 8:36 ` Paolo Bonzini
2015-06-05 6:33 ` Xiao Guangrong
2015-05-30 10:59 ` [PATCH 15/15] KVM: VMX: fully implement guest MTRR virtualization Xiao Guangrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557651BF.5060900@linux.intel.com \
--to=guangrong.xiao@linux.intel.com \
--cc=dmatlack@google.com \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).