From mboxrd@z Thu Jan  1 00:00:00 1970
From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
Subject: Re: [PATCH 09/15] KVM: MTRR: introduce var_mtrr_range
Date: Tue, 09 Jun 2015 10:38:55 +0800
Message-ID: <557651BF.5060900@linux.intel.com>
References: <1432983566-15773-1-git-send-email-guangrong.xiao@linux.intel.com> <1432983566-15773-10-git-send-email-guangrong.xiao@linux.intel.com> <CALzav=fSxAb8cK8icBkcyVovuEsiz3muhL6HPJEUS+MLmw4dqQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Gleb Natapov <gleb@kernel.org>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	kvm list <kvm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
To: David Matlack <dmatlack@google.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <CALzav=fSxAb8cK8icBkcyVovuEsiz3muhL6HPJEUS+MLmw4dqQ@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org


Thanks for your review, David!


On 06/09/2015 08:36 AM, David Matlack wrote:

>>   static void update_mtrr(struct kvm_vcpu *vcpu, u32 msr)
>>   {
>>          struct kvm_mtrr *mtrr_state = &vcpu->arch.mtrr_state;
>> -       gfn_t start, end, mask;
>> +       gfn_t start, end;
>>          int index;
>>
>>          if (msr == MSR_IA32_CR_PAT || !tdp_enabled ||
>> @@ -244,11 +255,7 @@ static void update_mtrr(struct kvm_vcpu *vcpu, u32 msr)
>>          default:
>>                  /* variable range MTRRs. */
>>                  index = (msr - 0x200) / 2;
>> -               start = mtrr_state->var_ranges[index].base & PAGE_MASK;
>> -               mask = mtrr_state->var_ranges[index].mask & PAGE_MASK;
>> -               mask |= ~0ULL << cpuid_maxphyaddr(vcpu);
>
> Why did you drop this in favor of boot_cpu_data.x86_phys_bits?
>

It can make the code more generic, @vcpu is not needed anymore.