From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [PATCH v2 08/13] KVM: implement multiple address spaces Date: Tue, 09 Jun 2015 11:20:08 +0800 Message-ID: <55765B68.1010300@linux.intel.com> References: <1432746314-50196-1-git-send-email-pbonzini@redhat.com> <1432746314-50196-9-git-send-email-pbonzini@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: rkrcmar@redhat.com, bdas@redhat.com To: Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Return-path: In-Reply-To: <1432746314-50196-9-git-send-email-pbonzini@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 05/28/2015 01:05 AM, Paolo Bonzini wrote: > /* > @@ -772,6 +776,7 @@ int __kvm_set_memory_region(struct kvm *kvm, > struct kvm_memory_slot *slot; > struct kvm_memory_slot old, new; > struct kvm_memslots *slots = NULL, *old_memslots; > + int as_id, id; > enum kvm_mr_change change; > > r = check_memory_region_flags(mem); > @@ -779,24 +784,27 @@ int __kvm_set_memory_region(struct kvm *kvm, > goto out; > > r = -EINVAL; > + as_id = mem->slot >> 16; > + id = mem->slot & 65535; > + A minor comment, Could you put these decoding into a separate function? Nice idea indeed. Reviewed-by: Xiao Guangrong