From: Jiri Slaby <jslaby@suse.cz>
To: James Hogan <james.hogan@imgtec.com>, stable <stable@vger.kernel.org>
Cc: Nicholas Mc Guire <hofrat@osadl.org>,
Gleb Natapov <gleb@kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Ralf Baechle <ralf@linux-mips.org>,
kvm@vger.kernel.org, linux-mips@linux-mips.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: KVM: do not sign extend on unsigned MMIO load
Date: Wed, 10 Jun 2015 14:57:02 +0200 [thread overview]
Message-ID: <5578341E.3020709@suse.cz> (raw)
In-Reply-To: <5575536E.8080608@imgtec.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
On 06/08/2015, 10:33 AM, James Hogan wrote:
> Hi stable folk,
>
> On 08/05/15 15:16, James Hogan wrote:
>> On 07/05/15 13:47, Nicholas Mc Guire wrote:
>>> Fix possible unintended sign extension in unsigned MMIO loads
>>> by casting to uint16_t in the case of mmio_needed != 2.
>>>
>>> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
>>
>> Looks good to me. I wrote an MMIO test to reproduce the issue,
>> and this fixes it.
>>
>> Reviewed-by: James Hogan <james.hogan@imgtec.com> Tested-by:
>> James Hogan <james.hogan@imgtec.com>
>>
>> It looks suitable for stable too (3.10+).
>
> This has reached mainline, commit
> ed9244e6c534612d2b5ae47feab2f55a0d4b4ced
>
> Please could it be added to stable (3.10+).
Applied to 3.12. Thanks.
- --
js
suse labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQIcBAEBCAAGBQJVeDQcAAoJEL0lsQQGtHBJ7q4P/3Q7y1FHwPKDhsdIdyyRypR6
OXaH/6eNzpBhvSngP1gnx9MiyESTYihFVlRJsV6hYYzRcippnU0BP88dx9ntYrc1
Accbhj/PPYcMqfCnYdL80Kxt9EomeuxEDcCdbp8twnReTt44xNAGHePiNh9GrhjG
VKBMralyyjymtwyamCGb2W2aLNhxELIG3gXJTb7Q7E071LVeqQA6g+VNQ2QHwFYq
FkJexePsLu/j3zVxH+rsQPJA6E1oKfUJb3jQHAtZHAH95Um0r8T4jUVSgFhyk3r6
9tlkazL3P8Iui6lxbrV1vNCPAhhucY7PmX99uGhdroKJOKDCDPsVOKyJbxeHrUBR
3zrMpB9x2uXd6WpDLDfL+bI8bCG6NVXZPGgSd7P+r/UbNuZ6VBNSVdqlWUeoMWGR
ZS+HFMxVOiNplYudCTdLbJDLhm2XCWeW2lqszll/8Nk1c1FZkl8YbgpmdXfutKeU
LQfUfS4tr0AQ7BqXf3bPUGrSGZO7e1V5R4gAa+Yqo6ZjDOj20AjYvs0oW4ubgLg8
OJrHcJDLkEKrMDIZ7qpRZxyz56yrOgcfVbYB1fudXaV+e38t+kO0sujdNSJnHK8h
T3kfa96QW2gOi7Cys1o2OaQboY2wFxK3/YefX3Jn+N7tGedKUwF4IYHtj17YqX1/
8BkHSZZ9HQsJqyRAXBux
=qlvA
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2015-06-10 12:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-07 12:47 [PATCH] MIPS: KVM: do not sign extend on unsigned MMIO load Nicholas Mc Guire
2015-05-08 14:16 ` James Hogan
2015-06-08 8:33 ` James Hogan
2015-06-10 12:57 ` Jiri Slaby [this message]
2015-06-12 12:07 ` Luis Henriques
2015-06-19 19:14 ` Greg KH
2015-07-08 14:25 ` [PATCH stable <3.17] MIPS: KVM: Do " James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5578341E.3020709@suse.cz \
--to=jslaby@suse.cz \
--cc=gleb@kernel.org \
--cc=hofrat@osadl.org \
--cc=james.hogan@imgtec.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=pbonzini@redhat.com \
--cc=ralf@linux-mips.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).