From: Alexander Graf <agraf@suse.de>
To: Will Deacon <will.deacon@arm.com>,
Andre Przywara <andre.przywara@arm.com>
Cc: "kvm-ppc@vger.kernel.org" <kvm-ppc@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Matt Evans <Matt.Evans@arm.com>
Subject: Re: [PATCH 1/3] powerpc: implement barrier primitives
Date: Wed, 17 Jun 2015 12:46:37 +0200 [thread overview]
Message-ID: <5581500D.1060900@suse.de> (raw)
In-Reply-To: <20150617101506.GD6303@arm.com>
On 17.06.15 12:15, Will Deacon wrote:
> On Wed, Jun 17, 2015 at 10:43:48AM +0100, Andre Przywara wrote:
>> Instead of referring to the Linux header including the barrier
>> macros, copy over the rather simple implementation for the PowerPC
>> barrier instructions kvmtool uses. This fixes build for powerpc.
>>
>> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
>> ---
>> Hi,
>>
>> I just took what kvmtool seems to have used before, I actually have
>> no idea if "sync" is the right instruction or "lwsync" would do.
>> Would be nice if some people with PowerPC knowledge could comment.
>
> I *think* we can use lwsync for rmb and wmb, but would want confirmation
> from a ppc guy before making that change!
Also I'd prefer to play safe for now :)
Alex
next prev parent reply other threads:[~2015-06-17 10:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 9:43 [PATCH 0/3] kvmtool: fixes for PowerPC Andre Przywara
2015-06-17 9:43 ` [PATCH 1/3] powerpc: implement barrier primitives Andre Przywara
2015-06-17 10:15 ` Will Deacon
2015-06-17 10:46 ` Alexander Graf [this message]
2015-06-18 9:11 ` Michael Ellerman
2015-06-18 9:38 ` Will Deacon
2015-06-17 9:43 ` [PATCH 2/3] powerpc: use default endianness for converting guest/init Andre Przywara
2015-06-18 14:52 ` Andre Przywara
2015-06-19 1:08 ` Michael Ellerman
2015-06-19 16:15 ` Andre Przywara
2015-06-21 20:01 ` Michael Ellerman
2015-06-17 9:43 ` [PATCH 3/3] powerpc: add hvcall.h header from Linux Andre Przywara
2015-06-17 10:13 ` Will Deacon
2015-06-18 9:15 ` Michael Ellerman
2015-06-18 10:10 ` [PATCH v2] " Andre Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5581500D.1060900@suse.de \
--to=agraf@suse.de \
--cc=Matt.Evans@arm.com \
--cc=andre.przywara@arm.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=svaidy@linux.vnet.ibm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).