From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [PATCH v2 09/13] KVM: x86: pass kvm_mmu_page to gfn_to_rmap Date: Thu, 18 Jun 2015 12:41:32 +0800 Message-ID: <55824BFC.7080509@linux.intel.com> References: <1432746314-50196-1-git-send-email-pbonzini@redhat.com> <1432746314-50196-10-git-send-email-pbonzini@redhat.com> <55765D43.8090302@linux.intel.com> <55812CB1.6030805@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: rkrcmar@redhat.com, bdas@redhat.com To: Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Return-path: In-Reply-To: <55812CB1.6030805@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 06/17/2015 04:15 PM, Paolo Bonzini wrote: > > > On 09/06/2015 05:28, Xiao Guangrong wrote: >>> >>> - rmapp = gfn_to_rmap(kvm, sp->gfn, PT_PAGE_TABLE_LEVEL); >>> + slots = kvm_memslots(kvm); >>> + slot = __gfn_to_memslot(slots, sp->gfn); >>> + rmapp = __gfn_to_rmap(sp->gfn, PT_PAGE_TABLE_LEVEL, slot); >>> >> >> Why @sp is not available here? > > Because the function forces the level to be PT_PAGE_TABLE_LEVEL rather > than sp->level. Oh, right, thanks for your explanation. :) Reviewed-by: Xiao Guangrong