From: Paolo Bonzini <pbonzini@redhat.com>
To: Wei Huang <wei@redhat.com>,
kvm@vger.kernel.org, x86@kernel.org, gleb@kernel.org,
rkrcmar@redhat.com, joro@8bytes.org
Subject: Re: [PATCH V5 2/4] KVM: x86/vPMU: Create vPMU interface for VMX and SVM
Date: Fri, 19 Jun 2015 13:31:54 +0200 [thread overview]
Message-ID: <5583FDAA.7010006@redhat.com> (raw)
In-Reply-To: <1434087296-27141-3-git-send-email-wei@redhat.com>
On 12/06/2015 07:34, Wei Huang wrote:
> -static void trigger_pmi(struct irq_work *irq_work)
> +static void kvm_pmi_trigger_fn(struct irq_work *irq_work)
> {
> - struct kvm_pmu *pmu = container_of(irq_work, struct kvm_pmu,
> - irq_work);
> - struct kvm_vcpu *vcpu = container_of(pmu, struct kvm_vcpu,
> - arch.pmu);
> + struct kvm_pmu *pmu = container_of(irq_work, struct kvm_pmu, irq_work);
> + struct kvm_vcpu *vcpu = pmu_to_vcpu(pmu);
>
> - kvm_deliver_pmi(vcpu);
> + kvm_pmu_deliver_pmi(vcpu);
> }
>
On the other hand, this patch really should have been split further.
For example, just looking at this snippet you can see that the
introduction of pmu_to_vcpu and the function renames should have been
separate from the creation of the vPMU interface.
Paolo
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
next prev parent reply other threads:[~2015-06-19 11:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-12 5:34 [PATCH V5 0/4] Consolidated KVM vPMU support for x86 Wei Huang
2015-06-12 5:34 ` [PATCH V5 1/4] KVM: x86/vPMU: Define kvm_pmu_ops to support vPMU function dispatch Wei Huang
2015-06-19 11:30 ` Paolo Bonzini
2015-06-19 14:34 ` Wei Huang
2015-06-12 5:34 ` [PATCH V5 2/4] KVM: x86/vPMU: Create vPMU interface for VMX and SVM Wei Huang
2015-06-16 15:40 ` Joerg Roedel
2015-06-19 11:31 ` Paolo Bonzini [this message]
2015-06-19 14:36 ` Wei Huang
2015-06-12 5:34 ` [PATCH V5 3/4] KVM: x86/vPMU: Implement AMD vPMU code for KVM Wei Huang
2015-06-12 5:34 ` [PATCH V5 4/4] KVM: x86/vPMU: Enable PMU handling for AMD PERFCTRn and EVNTSELn MSRs Wei Huang
2015-06-16 15:41 ` [PATCH V5 0/4] Consolidated KVM vPMU support for x86 Joerg Roedel
2015-06-19 15:14 ` Paolo Bonzini
2015-06-19 15:40 ` Wei Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5583FDAA.7010006@redhat.com \
--to=pbonzini@redhat.com \
--cc=gleb@kernel.org \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=rkrcmar@redhat.com \
--cc=wei@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).