From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH v5] i386: Introduce ARAT CPU feature Date: Tue, 23 Jun 2015 07:04:52 +0200 Message-ID: <5588E8F4.8080701@web.de> References: <55740B9C.6030107@web.de> <20150618202159.GK3874@thinpad.lan.raisama.net> <5586F67E.5010708@web.de> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="mdUovPQ1OQLXidLqMLD8WM9sotisWosPt" Cc: Paolo Bonzini , qemu-devel , kvm , "Michael S. Tsirkin" , Marcelo Tosatti To: Wanpeng Li , Eduardo Habkost Return-path: Received: from mout.web.de ([212.227.15.14]:64105 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750766AbbFWFFE (ORCPT ); Tue, 23 Jun 2015 01:05:04 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --mdUovPQ1OQLXidLqMLD8WM9sotisWosPt Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 2015-06-23 04:50, Wanpeng Li wrote: >=20 >=20 > On 6/22/15 1:38 AM, Jan Kiszka wrote: >> On 2015-06-18 22:21, Eduardo Habkost wrote: >>> On Sun, Jun 07, 2015 at 11:15:08AM +0200, Jan Kiszka wrote: >>>> From: Jan Kiszka >>>> >>>> ARAT signals that the APIC timer does not stop in power saving state= s. >>>> As our APICs are emulated, it's fine to expose this feature to guest= s, >>>> at least when asking for KVM host features or with CPU types that >>>> include the flag. The exact model number that introduced the feature= is >>>> not known, but reports can be found that it's at least available sin= ce >>>> Sandy Bridge. >>>> >>>> Signed-off-by: Jan Kiszka >>> The code looks good now, but: what are the real consequences of >>> enabling/disabling the flag? What exactly guests use it for? >>> >>> Isn't this going to make guests have additional expectations about th= e >>> APIC timer that may be broken when live-migrating or pausing the VM? >> ARAT only refers to stopping of the timer in certain power states (whi= ch >> we do not even emulate IIRC). In that case, the OS is under risk of >> sleeping forever, thus need to look for a different wakeup source. >=20 > HPET will always be the default broadcast event device I think. But it's unused (under Linux) if per-cpu clockevents are unaffected by CLOCK_EVT_FEAT_C3STOP (x86-only "none-feature"), i.e. have ARAT set. And other guests may have other strategies to deal with missing ARAT. Again, the scenario for me was not a regular setup but some Jailhouse boot of Linux where neither a HPET nor a PIT are available as broadcast sources and Linux therefore refuses to switch to hires mode - in contrast to running on real hardware. Jan --mdUovPQ1OQLXidLqMLD8WM9sotisWosPt Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlWI6PQACgkQitSsb3rl5xQVgwCfUjIGF0cBuZs1h+o5Cidm1Iw6 eScAnA+VCxHx+HqICqEAlPIRFqbdadHy =NEz+ -----END PGP SIGNATURE----- --mdUovPQ1OQLXidLqMLD8WM9sotisWosPt-- -- To unsubscribe from this list: send the line "unsubscribe kvm" in