From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 11/11] qemu/kvm: mark in cpu state that hyper-v crash occured Date: Tue, 23 Jun 2015 11:53:14 +0200 Message-ID: <55892C8A.20601@redhat.com> References: <1434989108-20924-1-git-send-email-den@openvz.org> <1434989108-20924-12-git-send-email-den@openvz.org> <55883686.2090209@suse.de> <55883760.6010502@redhat.com> <558838F6.1080507@suse.de> <558839A9.9040009@redhat.com> <55884A12.2020806@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: "Denis V. Lunev" , kvm@vger.kernel.org, qemu-devel@nongnu.org, Andrey Smetanin , Juan Quintela To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Return-path: Received: from mx1.redhat.com ([209.132.183.28]:40163 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751256AbbFWJxS (ORCPT ); Tue, 23 Jun 2015 05:53:18 -0400 In-Reply-To: <55884A12.2020806@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: On 22/06/2015 19:46, Andreas F=C3=A4rber wrote: >>>>> >>>> On the other hand, I wonder if current_cpu is available in >>>>> >>>> qemu_system_guest_panicked. If so, you could add the field = to the >>>>> >>>> generic CPUState struct and migrate it as a subsection of >>>>> >>>> vmstate_cpu_common. >>> >> Hm, not sure whether it is. >> >=20 >> > It should be... > Obviously depends on the call site. :) At some point in cpu-exec.c, > current_cpu gets set to NULL. So the function would at least deserve = a > comment on when (not to) use it. I think it could be used anyway even if current_cpu. The difference would be whether the crash is attached to a CPU or not. Paolo