From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Zyngier Subject: Re: [PATCH] arm64/kvm: Add generic v8 KVM target Date: Wed, 24 Jun 2015 09:29:56 +0100 Message-ID: <558A6A84.5020603@arm.com> References: <1434531646-4873-1-git-send-email-suzuki.poulose@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: "timur@codeaurora.org" , "vgandhi@codeaurora.org" , kvm-devel , arm-mail-list , "kvmarm@lists.cs.columbia.edu" To: Peter Maydell , Suzuki Poulose Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu List-Id: kvm.vger.kernel.org On 22/06/15 09:44, Peter Maydell wrote: > On 17 June 2015 at 10:00, Suzuki K. Poulose wrote: >> From: "Suzuki K. Poulose" >> >> This patch adds a generic ARM v8 KVM target cpu type for use >> by the new CPUs which eventualy ends up using the common sys_reg >> table. For backward compatibility the existing targets have been >> preserved. Any new target CPU that can be covered by generic v8 >> sys_reg tables should make use of the new generic target. > > How do you intend this to work for cross-host migration? It is not meant to work for cross migration at all. > Is the idea that the kernel guarantees that "generic" looks > 100% the same to the guest regardless of host hardware? I'm > not sure that can be made to work, given impdef differences > in ID register values, bp/wp registers, and so on. > > Given that, it seems to me that we still need to provide > KVM_ARM_TARGET_$THISCPU defines so userspace can request > a specific guest CPU flavour; so what does this patch > provide that isn't already provided by just having userspace > query for the "preferred" CPU type as it does already? The way I see this working is that a "generic" CPU cannot be migrated (because we don't know anything about it). If it can be identified as a known (non generic) implementation, then we can migrate it. M. -- Jazz is not dead. It just smells funny...