From: Paolo Bonzini <pbonzini@redhat.com>
To: "Wu, Feng" <feng.wu@intel.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "mtosatti@redhat.com" <mtosatti@redhat.com>,
"alex.williamson@redhat.com" <alex.williamson@redhat.com>,
"eric.auger@linaro.org" <eric.auger@linaro.org>
Subject: Re: [v4 01/16] KVM: Extend struct pi_desc for VT-d Posted-Interrupts
Date: Wed, 24 Jun 2015 10:46:06 +0200 [thread overview]
Message-ID: <558A6E4E.90907@redhat.com> (raw)
In-Reply-To: <E959C4978C3B6342920538CF579893F0025C8989@SHSMSX104.ccr.corp.intel.com>
On 24/06/2015 07:42, Wu, Feng wrote:
> Do you mean we don't use bitfields at all, or the following format is
> acceptable, in which, we use bitfileds as less as possible?
> union {
> struct
> {
> u16 on : 1, /* bit 256 - Outstanding Notification */
> sn : 1, /* bit 257 - Suppress Notification */
> rsvd_1 : 14; /* bit 271:258 - Reserved */
> u8 nv; /* bit 279:272 - Notification Vector */
> u8 rsvd_2; /* bit 287:280 - Reserved */
> u32 ndst; /* bit 319:288 - Notification Destination */
> };
> u64 control;
This is okay.
Paolo
next prev parent reply other threads:[~2015-06-24 8:46 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-11 10:51 [v4 00/16] Add VT-d Posted-Interrupts support Feng Wu
2015-06-11 10:51 ` [v4 01/16] KVM: Extend struct pi_desc for VT-d Posted-Interrupts Feng Wu
2015-06-23 15:49 ` Paolo Bonzini
2015-06-24 5:42 ` Wu, Feng
2015-06-24 8:46 ` Paolo Bonzini [this message]
2015-06-11 10:51 ` [v4 02/16] KVM: Add some helper functions for Posted-Interrupts Feng Wu
2015-06-11 10:51 ` [v4 03/16] KVM: Define a new interface kvm_intr_is_single_vcpu() Feng Wu
2015-06-11 10:51 ` [v4 04/16] KVM: Get Posted-Interrupts descriptor address from struct kvm_vcpu Feng Wu
2015-06-11 10:51 ` [v4 05/16] KVM: Add interfaces to control PI outside vmx Feng Wu
2015-06-11 10:51 ` [v4 06/16] KVM: Make struct kvm_irq_routing_table accessible Feng Wu
2015-06-11 10:51 ` [v4 07/16] KVM: make kvm_set_msi_irq() public Feng Wu
2015-06-11 10:51 ` [v4 08/16] KVM: kvm-vfio: User API for IRQ forwarding Feng Wu
2015-06-11 13:37 ` Eric Auger
2015-06-12 0:20 ` Wu, Feng
2015-06-11 19:59 ` Avi Kivity
2015-06-12 0:23 ` Wu, Feng
2015-06-12 15:41 ` Alex Williamson
2015-06-12 18:48 ` Avi Kivity
2015-06-12 19:03 ` Alex Williamson
2015-06-15 6:42 ` Wu, Feng
2015-06-15 16:17 ` Eric Auger
2015-06-15 16:45 ` Alex Williamson
2015-06-18 9:16 ` Wu, Feng
2015-06-18 20:04 ` Alex Williamson
2015-06-24 15:46 ` Joerg Roedel
2015-06-25 1:54 ` Wu, Feng
2015-06-25 9:37 ` Wu, Feng
2015-06-25 15:11 ` Alex Williamson
2015-06-29 9:06 ` Joerg Roedel
2015-06-29 9:14 ` Wu, Feng
2015-06-29 9:22 ` Joerg Roedel
2015-06-29 13:01 ` Wu, Feng
2015-06-29 13:27 ` Wu, Feng
2015-06-29 15:18 ` Alex Williamson
2015-06-24 15:50 ` Joerg Roedel
2015-06-24 16:25 ` Eric Auger
2015-06-24 19:49 ` Alex Williamson
2015-06-25 1:57 ` Wu, Feng
2015-06-11 10:51 ` [v4 09/16] VFIO: external user API for interaction Feng Wu
2015-06-11 10:51 ` [v4 10/16] KVM: kvm-vfio: wrappers to VFIO external API device helpers Feng Wu
2015-06-11 10:51 ` [v4 11/16] KVM: kvm-vfio: User API for VT-d Posted-Interrupts Feng Wu
2015-06-11 10:51 ` [v4 12/16] KVM: kvm-vfio: implement the VFIO skeleton " Feng Wu
2015-06-11 17:15 ` Alex Williamson
2015-06-12 4:54 ` Wu, Feng
2015-06-12 14:51 ` Alex Williamson
2015-06-23 16:00 ` Paolo Bonzini
2015-06-11 10:51 ` [v4 13/16] KVM: x86: kvm-vfio: VT-d posted-interrupts setup Feng Wu
2015-06-11 17:16 ` Alex Williamson
2015-06-12 4:58 ` Wu, Feng
2015-06-11 10:51 ` [v4 14/16] KVM: Update Posted-Interrupts Descriptor when vCPU is preempted Feng Wu
2015-06-11 10:51 ` [v4 15/16] KVM: Update Posted-Interrupts Descriptor when vCPU is blocked Feng Wu
2015-06-23 16:05 ` Paolo Bonzini
2015-06-11 10:51 ` [v4 16/16] KVM: Warn if 'SN' is set during posting interrupts by software Feng Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558A6E4E.90907@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=eric.auger@linaro.org \
--cc=feng.wu@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).