From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [v4 01/16] KVM: Extend struct pi_desc for VT-d Posted-Interrupts Date: Wed, 24 Jun 2015 10:46:06 +0200 Message-ID: <558A6E4E.90907@redhat.com> References: <1434019912-15423-1-git-send-email-feng.wu@intel.com> <1434019912-15423-2-git-send-email-feng.wu@intel.com> <5589801A.2090203@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Cc: "mtosatti@redhat.com" , "alex.williamson@redhat.com" , "eric.auger@linaro.org" To: "Wu, Feng" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Return-path: Received: from mail-wg0-f51.google.com ([74.125.82.51]:36135 "EHLO mail-wg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750800AbbFXIqK (ORCPT ); Wed, 24 Jun 2015 04:46:10 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 24/06/2015 07:42, Wu, Feng wrote: > Do you mean we don't use bitfields at all, or the following format is > acceptable, in which, we use bitfileds as less as possible? > union { > struct > { > u16 on : 1, /* bit 256 - Outstanding Notification */ > sn : 1, /* bit 257 - Suppress Notification */ > rsvd_1 : 14; /* bit 271:258 - Reserved */ > u8 nv; /* bit 279:272 - Notification Vector */ > u8 rsvd_2; /* bit 287:280 - Reserved */ > u32 ndst; /* bit 319:288 - Notification Destination */ > }; > u64 control; This is okay. Paolo