From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [Qemu-devel] [PATCH 00/16] implement vNVDIMM Date: Thu, 2 Jul 2015 11:52:58 +0200 Message-ID: <559509FA.20509@redhat.com> References: <1435762232-15543-1-git-send-email-guangrong.xiao@linux.intel.com> <20150702092044.GB20198@stefanha-thinkpad.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: imammedo@redhat.com, ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, rth@twiddle.net, =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= To: Stefan Hajnoczi , Xiao Guangrong Return-path: Received: from mx1.redhat.com ([209.132.183.28]:51719 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751333AbbGBJxE (ORCPT ); Thu, 2 Jul 2015 05:53:04 -0400 In-Reply-To: <20150702092044.GB20198@stefanha-thinkpad.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 02/07/2015 11:20, Stefan Hajnoczi wrote: > > Currently, the NVDIMM driver has been merged into upstream Linux Ke= rnel and > > this patchset tries to enable it in virtualization field >=20 > From a device model perspective, have you checked whether it makes se= nse > to integrate nvdimms into the pc-dimm and hostmem code that is used f= or > memory hotplug and NUMA? >=20 > The NVDIMM device in your patches is a completely new TYPE_DEVICE so = it > doesn't share any interfaces or code with existing memory devices. > Maybe that is the right solution here because NVDIMMs have different > characteristics, but I'm not sure. The hostmem code should definitely be shared, e.g. by adding a new "file" property to the memory-backend-file class. ivshmem can also use it---CCing Marc-Andr=E9. I don't know about the pc-dimm devices. If the NVDIMM devices can do _OST and can be hotplugged, then the answer is probably yes. Paolo