From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 11/12] qemu: add crash_occurred flag into CPUState
Date: Thu, 2 Jul 2015 18:26:02 +0200
Message-ID: <5595661A.1050303@redhat.com>
References: <1435853275-5440-1-git-send-email-den@openvz.org>
 <1435853275-5440-12-git-send-email-den@openvz.org> <5595645A.6070402@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org,
	Andrey Smetanin <asmetanin@virtuozzo.com>
To: =?UTF-8?Q?Andreas_F=c3=a4rber?= <afaerber@suse.de>,
	"Denis V. Lunev" <den@openvz.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:43327 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753736AbbGBQ0H (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 2 Jul 2015 12:26:07 -0400
In-Reply-To: <5595645A.6070402@suse.de>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>



On 02/07/2015 18:18, Andreas F=C3=A4rber wrote:
>> > +    uint32_t crash_occurred;
>> >      volatile sig_atomic_t exit_request;
>> >      uint32_t interrupt_request;
>> >      int singlestep_enabled;
> If you add this field to CPUState, you'll also need to reset it in
> qom/cpu.c. Or is it intentionally persistent?

And since you are at it, you can make it a bool.

Paolo