From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 12/12] i386/kvm: Hyper-v crash msrs set/get'ers and
 migration
Date: Tue, 7 Jul 2015 12:21:48 +0200
Message-ID: <559BA83C.6050702@redhat.com>
References: <1435924905-8926-1-git-send-email-den@openvz.org>
 <1435924905-8926-13-git-send-email-den@openvz.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org,
	Andrey Smetanin <asmetanin@virtuozzo.com>,
	=?UTF-8?Q?Andreas_F=c3=a4rber?= <afaerber@suse.de>
To: "Denis V. Lunev" <den@openvz.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:43016 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753325AbbGGKVw (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 7 Jul 2015 06:21:52 -0400
In-Reply-To: <1435924905-8926-13-git-send-email-den@openvz.org>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>



On 03/07/2015 14:01, Denis V. Lunev wrote:
> @@ -904,6 +905,7 @@ typedef struct CPUX86State {
>      uint64_t msr_hv_guest_os_id;
>      uint64_t msr_hv_vapic;
>      uint64_t msr_hv_tsc;
> +    uint64_t msr_hv_crash_prm[HV_X64_MSR_CRASH_PARAMS];

Do not abbreviate variable names!  The enum even says PARAMS, so use
params in the array name as well.

I've done the change locally in all files.

Paolo

>      /* exception/interrupt handling */
>      int error_code;