From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 1/4] KVM: count number of assigned devices Date: Tue, 7 Jul 2015 17:36:35 +0200 Message-ID: <559BF203.2010202@redhat.com> References: <1436276739-50326-1-git-send-email-pbonzini@redhat.com> <1436276739-50326-2-git-send-email-pbonzini@redhat.com> <1436282525.1391.42.camel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, guangrong.xiao@linux.intel.com, jroedel@suse.de, ogerlitz@mellanox.com, amirv@mellanox.com To: Alex Williamson Return-path: In-Reply-To: <1436282525.1391.42.camel@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 07/07/2015 17:22, Alex Williamson wrote: >> > -#define __KVM_HAVE_ARCH_NONCOHERENT_DMA >> > +#define __KVM_HAVE_ARCH_VFIO_HOOKS > Do we really want to tie these two things together under something > that's not strictly a "vfio" option? Legacy assignment also makes use > of these, as shown in this patch, but even if we consider that temporary > until legacy assignment is removed, I can imagine platforms that might > care about one but not the other. I don't really see the harm in using > a separate #define, perhaps __KVM_HAVE_ARCH_ASSIGNED_DEVICE. Thanks, Sure, that's okay. Paolo