From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [PATCH 2/4] KVM: SVM: use NPT page attributes Date: Sat, 11 Jul 2015 00:02:59 +0800 Message-ID: <559FECB3.1060506@linux.intel.com> References: <1436276739-50326-1-git-send-email-pbonzini@redhat.com> <1436276739-50326-3-git-send-email-pbonzini@redhat.com> <559CBC4E.2090004@linux.intel.com> <559D0754.6030009@redhat.com> <559DDCD0.2090502@linux.intel.com> <559E90C1.6000605@redhat.com> <559F1D90.3070001@linux.intel.com> <559FA2CC.9000607@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: jroedel@suse.de, alex.williamson@redhat.com, ogerlitz@mellanox.com, amirv@mellanox.com To: Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Return-path: In-Reply-To: <559FA2CC.9000607@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 07/10/2015 06:47 PM, Paolo Bonzini wrote: > > > On 10/07/2015 03:19, Xiao Guangrong wrote: >>> yes, this is correct. QEMU still does not have support for disabling >>> "quirks", so gCR0.CD is currently hidden on SVM. I would like to >>> include this series in 4.2, while for 4.3 I will disable the quirk above >>> altogether (it is superseded by the way PAT is forced to all-WB). >> >> That plan sounds good to me. >> >> You will drop disabled_quirks completely or just enable it in Qemu? :) > > I will drop this quirk completely. Other quirks (well, there's just > one) will remain. Make senses. The whole patchset looks good to me! Reviewed-by: Xiao Guangrong