kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marc Zyngier <marc.zyngier@arm.com>
To: Pavel Fedin <p.fedin@samsung.com>,
	"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH v2 0/3] KVM: arm/arm64: Allow to use KVM without in-kernel irqchip
Date: Fri, 24 Jul 2015 17:06:15 +0100	[thread overview]
Message-ID: <55B26277.80205@arm.com> (raw)
In-Reply-To: <008f01d0c625$45d91a90$d18b4fb0$@samsung.com>

On 24/07/15 16:27, Pavel Fedin wrote:
>>>  Ok, let's leave this API alone then for now...
>>>  Will then be a concensus if i tweak the thing a little bit and we just enable KVM without both
> vGIC
>>> and vTimer ? It will be an emulator's problem how to handle them then.
>>
>> Well, let's see the patches first, and how invasive they are.
> 
>  Please, i've just posted an RFC and cc'ed you.
>  I would say the implementation is very small. However, perhaps, it's not going to work with active
> state switching patch, because as far as i understand the whole thing depends on manipulations with
> ARCH_TIMER_CTRL_IT_MASK. Without it i'm going to get multiple interrupts instead of only one. It
> would be possible to signal the interrupt as real level-sensitive (since we will be tracking active
> state), but... it's not possible to know when to deactivate the line, hardware doesn't report that.

Then it is likely to be a lost cause. We need to get rid of the timer
masking crap, as it prevents us from running perfectly valid guests (QNX
being one). It also imposes the same hack on other guests (UEFI was
forced to implement the same horror).

As I said before, not having a VGIC pretty much puts you in an uncharted
territory, and the amount of hacks you have to introduce are not really
worth the effort in mainline.

It is rather sad, but I hope this serves as a lesson for whoever decides
to cut corner on HW implementation while thinking "SW will take care of
it". They usually shoot themselves in the foot.

	M.
-- 
Jazz is not dead. It just smells funny...

  reply	other threads:[~2015-07-24 16:06 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-14 12:06 [PATCH v2 0/3] KVM: arm/arm64: Allow to use KVM without in-kernel irqchip Pavel Fedin
2015-07-14 12:06 ` [PATCH v2 1/3] KVM: arm: Fix NULL pointer dereference if KVM is used " Pavel Fedin
2015-07-17 16:47   ` Marc Zyngier
2015-07-19 14:19     ` Pavel Fedin
2015-07-14 12:06 ` [PATCH v2 2/3] KVM: arm: Detect vGIC presence at runtime Pavel Fedin
2015-07-17 17:14   ` Marc Zyngier
2015-07-14 12:06 ` [PATCH v2 3/3] KVM: arm64: Introduce default dummy save/restore functions Pavel Fedin
2015-07-14 12:28   ` Marc Zyngier
2015-07-14 13:02     ` Pavel Fedin
2015-07-16 13:30       ` Christoffer Dall
2015-07-14 14:15     ` Pavel Fedin
2015-07-17 16:59 ` [PATCH v2 0/3] KVM: arm/arm64: Allow to use KVM without in-kernel irqchip Marc Zyngier
2015-07-19 14:05   ` Pavel Fedin
2015-07-20  8:08     ` Marc Zyngier
2015-07-22  7:19       ` Pavel Fedin
2015-07-23 16:48         ` Marc Zyngier
2015-07-24 15:27           ` Pavel Fedin
2015-07-24 16:06             ` Marc Zyngier [this message]
2015-07-26 12:50               ` Pavel Fedin
2015-07-27  7:28                 ` Marc Zyngier
2015-07-27  8:36                   ` Pavel Fedin
2015-07-27  9:02                     ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55B26277.80205@arm.com \
    --to=marc.zyngier@arm.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=p.fedin@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).