Kernel KVM virtualization development
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Andy Lutomirski <luto@amacapital.net>,
	KVM list <kvm@vger.kernel.org>,
	Arjan van de Ven <arjan@linux.intel.com>
Subject: Re: Should KVM_GUEST stop depending on PARAVIRT?
Date: Wed, 29 Jul 2015 11:41:26 +0200	[thread overview]
Message-ID: <55B89FC6.2050101@redhat.com> (raw)
In-Reply-To: <20150729094015.GL19282@twins.programming.kicks-ass.net>



On 29/07/2015 11:40, Peter Zijlstra wrote:
> > Well, people have complained about it because it's KERN_ERR.  Do you
> > think it is okay to downgrade this (perhaps not even just on VMs) to info?
>
> Ah, do people really have nothing better to do? ;-) Seems like a petty
> complaint.
> 
> Sure, it seems our check_hw_exists() does the same thing:
> 
>         printk("%sFailed to access perfctr msr (MSR %x is %Lx)\n",
>                 boot_cpu_has(X86_FEATURE_HYPERVISOR) ? KERN_INFO : KERN_ERR,
>                 reg, val_new);
> 
> so ERR for real hardware, INFO for hypervisor thingies.

Great, I'll send a patch then!

Paolo

  reply	other threads:[~2015-07-29  9:41 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-24 17:33 Should KVM_GUEST stop depending on PARAVIRT? Andy Lutomirski
2015-07-27 13:59 ` Paolo Bonzini
2015-07-27 15:56   ` Andy Lutomirski
2015-07-27 17:49     ` Paolo Bonzini
2015-07-27 17:51       ` Andy Lutomirski
2015-07-27 18:30         ` Paolo Bonzini
2015-07-27 18:45           ` Andy Lutomirski
2015-07-27 19:04             ` Arjan van de Ven
2015-07-28  9:57             ` Paolo Bonzini
2015-07-29  0:23               ` Andy Lutomirski
2015-07-29  4:49                 ` Venkatesh Srinivas
2015-07-29  8:27                   ` Paolo Bonzini
2015-07-29  9:19                 ` Peter Zijlstra
2015-07-29  9:24                   ` Paolo Bonzini
2015-07-29  9:40                     ` Peter Zijlstra
2015-07-29  9:41                       ` Paolo Bonzini [this message]
2015-07-30  0:14                         ` Andy Lutomirski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55B89FC6.2050101@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=arjan@linux.intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox