From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [kvm-unit-tests RFC PATCH] arm/tlbflush.c: TLB flushing torture test [DEV] Date: Wed, 29 Jul 2015 15:58:59 +0200 Message-ID: <55B8DC23.5040007@redhat.com> References: <1437744306-7911-1-git-send-email-alex.bennee@linaro.org> <20150727075411.GA3758@hawk.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: mttcg@greensocs.com, mark.burton@greensocs.com, fred.konrad@greensocs.com, a.spyridakis@virtualopensystems.com, kvm@vger.kernel.org To: Andrew Jones , =?UTF-8?Q?Alex_Benn=c3=a9e?= Return-path: Received: from mx1.redhat.com ([209.132.183.28]:43164 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750854AbbG2N7E (ORCPT ); Wed, 29 Jul 2015 09:59:04 -0400 In-Reply-To: <20150727075411.GA3758@hawk.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: On 27/07/2015 09:54, Andrew Jones wrote: > Also, please rename to tlbflush-test.c to differentiate it > from an implementation of tlbflush support, and to make > the standalone test name (if we commit those patches) more > descriptive. I disagree here. Support code would go in lib/arm. > As we're adding tests faster now it's becoming clear that the '\' list > isn't so great. To add a new test at the bottom we always have to modify > the last line too. We should either add the new one at the top (right > below the 'test-common =' line), or change this to a '+=' sequence like > some other lists are done. If you prefer += that's okay, but then please modify also cflatobjs in Makefile and the x86 fragments in config/. Paolo