From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 4/4] KVM: x86: clean/fix memory barriers in irqchip_in_kernel Date: Thu, 30 Jul 2015 09:26:00 +0200 Message-ID: <55B9D188.3020600@redhat.com> References: <1438176538-26191-1-git-send-email-pbonzini@redhat.com> <1438176538-26191-5-git-send-email-pbonzini@redhat.com> <20150730033208.GC15229@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, mtosatti@redhat.com, rkrcmar@redhat.com To: Steve Rutherford Return-path: In-Reply-To: <20150730033208.GC15229@google.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 30/07/2015 05:32, Steve Rutherford wrote: >> > + /* Write kvm->irq_routing before kvm->arch.vpic. */ >> > + smp_wmb(); > I assume this pairs with irqchip_in_kernel? Yes, see the comment added there by this same patch ("read kvm->arch.vpic before kvm->irq_routing"). Paolo