From: Paolo Bonzini <pbonzini@redhat.com>
To: Steve Rutherford <srutherford@google.com>,
KVM list <kvm@vger.kernel.org>
Subject: Re: [PATCH v7 4/4] KVM: x86: Add support for local interrupt requests from userspace
Date: Thu, 30 Jul 2015 10:21:38 +0200 [thread overview]
Message-ID: <55B9DE92.6050605@redhat.com> (raw)
In-Reply-To: <1438237303-19124-4-git-send-email-srutherford@google.com>
On 30/07/2015 08:21, Steve Rutherford wrote:
> Architectures: x86, ppc, mips
> Type: vcpu ioctl
> Parameters: struct kvm_interrupt (in)
> -Returns: 0 on success, -1 on error
> +Returns: 0 on success, negative on failure.
Really returns -1 because...
>
> -Queues a hardware interrupt vector to be injected. This is only
> -useful if in-kernel local APIC or equivalent is not used.
> +Queues a hardware interrupt vector to be injected.
>
> /* for KVM_INTERRUPT */
> struct kvm_interrupt {
> @@ -414,7 +413,14 @@ struct kvm_interrupt {
>
> X86:
>
> -Note 'irq' is an interrupt vector, not an interrupt pin or line.
> +Returns: 0 on success,
> + -EEXIST if an interrupt is already enqueued
> + -EINVAL the the irq number is invalid
> + -ENXIO if the PIC is in the kernel
> + -EFAULT if the pointer is invalid
... these are errno values. No need to resend.
Paolo
> +Note 'irq' is an interrupt vector, not an interrupt pin or line. This
> +ioctl is useful if the in-kernel PIC is not used.
next prev parent reply other threads:[~2015-07-30 8:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 6:21 [PATCH v7 1/4] KVM: x86: Split the APIC from the rest of IRQCHIP Steve Rutherford
2015-07-30 6:21 ` [PATCH v7 2/4] KVM: x86: Add KVM exit for IOAPIC EOIs Steve Rutherford
2015-07-30 6:21 ` [PATCH v7 3/4] KVM: x86: Add EOI exit bitmap inference Steve Rutherford
2015-07-30 6:21 ` [PATCH v7 4/4] KVM: x86: Add support for local interrupt requests from userspace Steve Rutherford
2015-07-30 8:21 ` Paolo Bonzini [this message]
2015-07-30 9:33 ` Paolo Bonzini
2015-07-30 8:21 ` [PATCH v7 1/4] KVM: x86: Split the APIC from the rest of IRQCHIP Paolo Bonzini
2015-07-30 8:37 ` Steve Rutherford
2015-07-30 9:38 ` Paolo Bonzini
2015-07-30 21:19 ` Steve Rutherford
2015-07-31 8:32 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B9DE92.6050605@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=srutherford@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).