From: Paolo Bonzini <pbonzini@redhat.com>
To: Bandan Das <bsd@redhat.com>
Cc: Shih-Wei Li <shihwei@cs.columbia.edu>, kvm@vger.kernel.org
Subject: Re: [PATCH kvm-unit-tests] x86: fix last commit
Date: Sun, 2 Aug 2015 09:47:02 +0200 [thread overview]
Message-ID: <55BDCAF6.6080907@redhat.com> (raw)
In-Reply-To: <jpglhdu904b.fsf@linux.bootlegged.copy>
On 01/08/2015 23:20, Bandan Das wrote:
>> > Actually it should be using the RTC alarm to wake itself up. But the
>> > firmware changed recently and the ACPI PMBASE moved from 0xb000 to
>> > 0x600. Try this (untested):
> Ah thanks! your patch works for me. Is this one of the static entries in
> the ACPI tables ? I am wondering if we can read this value so it works for
> everybody.
>
Yes, it's PM1a_STS from the PM1a_EVT block; the pointer is in the FADT.
x86/s3.c already has code to look for the FADT, so a fix should be easy.
On top of that we should move the ACPI tables to a header and the
parsing code to lib/x86, so that the vmexit test can use it to find the
PM_TMR address.
Paolo
prev parent reply other threads:[~2015-08-02 7:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 13:38 [PATCH kvm-unit-tests] x86: fix last commit Paolo Bonzini
2015-08-01 15:41 ` Shih-Wei Li
2015-08-01 19:05 ` Bandan Das
2015-08-01 20:49 ` Paolo Bonzini
2015-08-01 21:20 ` Bandan Das
2015-08-01 21:59 ` Shih-Wei Li
2015-08-02 7:47 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55BDCAF6.6080907@redhat.com \
--to=pbonzini@redhat.com \
--cc=bsd@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=shihwei@cs.columbia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox