From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [KVM x86 vPMU Patch 0/2] Two vPMU Trivial Patches Date: Tue, 11 Aug 2015 15:21:12 +0200 Message-ID: <55C9F6C8.5010807@redhat.com> References: <1438977210-24787-1-git-send-email-wei@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, gleb@kernel.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, joro@8bytes.org, trivial@kernel.org, drjones@redhat.com To: Wei Huang , kvm@vger.kernel.org Return-path: Received: from mail-wi0-f174.google.com ([209.85.212.174]:34728 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964835AbbHKNVY (ORCPT ); Tue, 11 Aug 2015 09:21:24 -0400 In-Reply-To: <1438977210-24787-1-git-send-email-wei@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 07/08/2015 21:53, Wei Huang wrote: > These two trivial patches are related to x86 vPMU code. They were > actually suggested by Andrew Jones while he was reviewing the last > big vPMU patch set. > > These patches have been compiled and tested on AMD system using > a 64-bit guest VM with various perf commands (e.g. bench, test, top, > stat). No obvious problems were found. > > Thanks, > -Wei > > Wei Huang (2): > KVM: x86/vPMU: Move the definition of kvm_pmu_ops to arch-specific > files > KVM: x86/vPMU: Fix unnecessary signed extesion for AMD PERFCTRn > > arch/x86/kvm/pmu.h | 2 -- > arch/x86/kvm/pmu_amd.c | 2 -- > arch/x86/kvm/svm.c | 1 + > arch/x86/kvm/vmx.c | 1 + > 4 files changed, 2 insertions(+), 4 deletions(-) > Applied patch 2. For patch 1 I'm not sure, because I do not really like 1) externs in .c files; 2) globals with no declarations in a .h file. So I'm leaving it out while I think more about it. Paolo