* Re: [PATCH] kvm:x86:Fix error handling in the function ioapic_write_indirect
[not found] <1439314758-23650-1-git-send-email-xerofoify@gmail.com>
@ 2015-08-12 12:45 ` Paolo Bonzini
0 siblings, 0 replies; only message in thread
From: Paolo Bonzini @ 2015-08-12 12:45 UTC (permalink / raw)
To: Nicholas Krause, gleb; +Cc: x86, kvm, linux-kernel
On 11/08/2015 19:39, Nicholas Krause wrote:
> This fixes error handling in the function ioapic_write_indirect to
> properly check if the call to the function ioapoc_service service
> has failed by not returning the value zero to indicate success to
> check if this occurs when calling this particular function and if
> so return immediately to the caller of ioapic_write_indirect due
> to us no longer being able to continue the function
> ioapic_write_indirect after this call fails.
This is not true.
You are back to the older problem that you are not trying to understand
the functions you are modifying.
Paolo
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2015-08-12 12:45 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1439314758-23650-1-git-send-email-xerofoify@gmail.com>
2015-08-12 12:45 ` [PATCH] kvm:x86:Fix error handling in the function ioapic_write_indirect Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).