From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH v2 5/5] KVM: refactor asynchronous vcpu ioctl dispatch Date: Thu, 13 Aug 2015 11:29:16 +0200 Message-ID: <55CC636C.9080202@redhat.com> References: <1438792381-19453-1-git-send-email-rkrcmar@redhat.com> <1438792381-19453-6-git-send-email-rkrcmar@redhat.com> <55CBA67C.1050703@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Christian Borntraeger , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , linux-kernel@vger.kernel.org Return-path: In-Reply-To: <55CBA67C.1050703@de.ibm.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 12/08/2015 22:03, Christian Borntraeger wrote: >> > #if defined(CONFIG_S390) || defined(CONFIG_PPC) || defined(CONFIG_MIPS) >> > - if (ioctl == KVM_S390_INTERRUPT || ioctl == KVM_S390_IRQ || ioctl == KVM_INTERRUPT) >> > - return kvm_arch_vcpu_ioctl(filp, ioctl, arg); >> > + case KVM_S390_INTERRUPT: >> > + case KVM_S390_IRQ: >> > + case KVM_INTERRUPT: > When you are it you might want to put the KVM_S390* withing CONFIG_S390 and > KVM_INTERRUPT within CONFIG_PPC || CONFIG_MIPS > > This might speed up the switch statement for s390/ppc/mips a tiny bit. It will add > another ifdef, though. Paolo? Sure. I wasn't sure of KVM_INTERRUPT's usage on s390. I'm okay with keeping the switch inline too, but if Radim prefers a function that's also fine. Paolo