kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Wanpeng Li" <wanpeng.li@hotmail.com>,
	"Radim Krčmář" <rkrcmar@redhat.com>,
	linux-kernel@vger.kernel.org
Cc: kvm@vger.kernel.org, Christian Borntraeger <borntraeger@de.ibm.com>
Subject: Re: [PATCH v3 2/5] KVM: add KVM_REQ_EXIT request for userspace exit
Date: Sat, 22 Aug 2015 00:04:55 -0700	[thread overview]
Message-ID: <55D81F17.8000907@redhat.com> (raw)
In-Reply-To: <BLU436-SMTP2157250AAE5CAE1E256309080660@phx.gbl>



On 19/08/2015 20:55, Wanpeng Li wrote:
>> The disadvantage is that it adds an overhead of one bit check for all
>> kernel exits.  A quick tracing shows that the ratio of userspace exits
>> after boot is about 1/5 and in subsequent run of nmap and kernel compile
>> has about 1/60, so the check should not regress global performance.
>>
>> All signal_pending() calls are userspace exit requests, so we add a
>> check for KVM_REQ_EXIT there.  There is one omitted call in kvm_vcpu_run
>> because KVM_REQ_EXIT is implied in earlier check for requests.
> 
> Actually I see more SIGUSR1 signals are intercepted by signal_pending()
> in vcpu_enter_guest() and vcpu_run() w/ win7 guest and kernel_irqchip=off.

You need more patches on the QEMU side.  I tested a version that is
mostly okay but not ready for upstream inclusion.

Paolo

  reply	other threads:[~2015-08-22  7:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-14 10:08 [PATCH v3 0/5] KVM: optimize userspace exits with a new ioctl Radim Krčmář
2015-08-14 10:08 ` [PATCH v3 1/5] KVM: add kvm_has_request wrapper Radim Krčmář
2015-08-14 10:08 ` [PATCH v3 2/5] KVM: add KVM_REQ_EXIT request for userspace exit Radim Krčmář
2015-08-20  3:55   ` Wanpeng Li
2015-08-22  7:04     ` Paolo Bonzini [this message]
2015-08-14 10:08 ` [PATCH v3 3/5] KVM: x86: add request_exits debug counter Radim Krčmář
2015-08-14 10:08 ` [PATCH v3 4/5] KVM: add KVM_USER_EXIT vcpu ioctl for userspace exit Radim Krčmář
2015-08-14 10:08 ` [PATCH v3 5/5] KVM: refactor asynchronous vcpu ioctl dispatch Radim Krčmář
2015-08-14 23:37 ` [PATCH v3 0/5] KVM: optimize userspace exits with a new ioctl Paolo Bonzini
2015-09-02 10:31 ` Christian Borntraeger
2015-09-07 12:33   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55D81F17.8000907@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rkrcmar@redhat.com \
    --cc=wanpeng.li@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).